ctome
/
tldr
mirror of https://github.com/CrimsonTome/tldr.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MAINTAINERS Guide: remove minimum merge wait time requirement (#11391)

pull/23/head
K.B.Dharun Krishna 2023-11-05 23:29:16 +05:30
parent bf375279fc
commit 13facb7c69
No known key found for this signature in database
GPG Key ID: 1B8ECA406788AFA4
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
contributing-guides/maintainers-guide.md
View File

@ -58,8 +58,7 @@ for the behavior expected of tldr-pages maintainers.
- PRs should be merged once they
(1) **pass the automated tests** (GitHub Actions, CLA signing, etc.),
(2) have the **review comments addressed**,
(3) get **approved reviews by two maintainers**, (the second maintainer can merge immediately after approving) and
(4) have been open for at least **24 hours** unless the changes are trivial
(3) get **approved reviews by two maintainers** (the second maintainer can merge immediately after approving).
- If a PR fails to get a review from a second maintainer after a few days,
the first maintainer should ping others for review. If it still lingers around