ctome
/
tldr
mirror of https://github.com/CrimsonTome/tldr.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

maintainers-guide: refresh (#6397)

beep
CleanMachine1 2021-10-21 08:16:17 +01:00 committed by GitHub
parent 1822def651
commit 99afbe2cf3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
contributing-guides/maintainers-guide.md
View File

@ -56,9 +56,9 @@ as a guideline for current and future maintainers.
- PRs should be merged once they
(1) **pass the automated tests** (GitHub Actions, CLA signing, etc.),
(2) have the **review comments addressed**, and
(3) get **approved reviews by two maintainers**
(the second maintainer can perform the merge immediately after accepting.)
(2) have the **review comments addressed**,
(3) get **approved reviews by two maintainers**, (the second maintainer can merge immediately after approving) and
(4) have been open for at least **24 hours** unless the changes are trivial
- If a PR fails to get a review from a second maintainer after a few days,
the first maintainer should ping others for review. If it still lingers around
@ -71,7 +71,7 @@ as a guideline for current and future maintainers.
and proceed with the merge process.
- If a PR **stops getting feedback from the submitter** and is marked as stale
by [probot-stale](../.github/stale.yml),
by [probot-stale](../.github/workflows/stale.yml),
any maintainer can choose to take over the PR
and make the necessary changes to get the content ready for merging.