mirror of https://github.com/CrimsonTome/tldr.git
maintainers-guide: refresh (#6397)
parent
1822def651
commit
99afbe2cf3
|
@ -56,9 +56,9 @@ as a guideline for current and future maintainers.
|
||||||
|
|
||||||
- PRs should be merged once they
|
- PRs should be merged once they
|
||||||
(1) **pass the automated tests** (GitHub Actions, CLA signing, etc.),
|
(1) **pass the automated tests** (GitHub Actions, CLA signing, etc.),
|
||||||
(2) have the **review comments addressed**, and
|
(2) have the **review comments addressed**,
|
||||||
(3) get **approved reviews by two maintainers**
|
(3) get **approved reviews by two maintainers**, (the second maintainer can merge immediately after approving) and
|
||||||
(the second maintainer can perform the merge immediately after accepting.)
|
(4) have been open for at least **24 hours** unless the changes are trivial
|
||||||
|
|
||||||
- If a PR fails to get a review from a second maintainer after a few days,
|
- If a PR fails to get a review from a second maintainer after a few days,
|
||||||
the first maintainer should ping others for review. If it still lingers around
|
the first maintainer should ping others for review. If it still lingers around
|
||||||
|
@ -71,7 +71,7 @@ as a guideline for current and future maintainers.
|
||||||
and proceed with the merge process.
|
and proceed with the merge process.
|
||||||
|
|
||||||
- If a PR **stops getting feedback from the submitter** and is marked as stale
|
- If a PR **stops getting feedback from the submitter** and is marked as stale
|
||||||
by [probot-stale](../.github/stale.yml),
|
by [probot-stale](../.github/workflows/stale.yml),
|
||||||
any maintainer can choose to take over the PR
|
any maintainer can choose to take over the PR
|
||||||
and make the necessary changes to get the content ready for merging.
|
and make the necessary changes to get the content ready for merging.
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue